Subject: |
Re: [Merge] lp:~johill-lanl/epics-base/epics-base-enclosure-of into lp:epics-base |
From: |
mdavidsaver <[email protected]> |
To: |
Jeff Hill <[email protected]> |
Date: |
Thu, 21 Nov 2013 14:15:36 -0000 |
On 11/20/13 20:37, Jeff Hill wrote:
...
> The offsetof() is implemented as a macro, and therefore less suitable
for use in templates.
While offsetof() can be implemented as a macro, with GCC it is a builtin
with additional checking. It is not specified to work on C++ classes.
Using reinterpret_cast<> to bypass these checks seems questionable to
me. I'm worried that this might involve Undefined Behavior.
> This implementation should work just fine with user defined types, and
I believe that the regression test should be testing that situation.
Your regression test don't cover the cases which I am worried about.
Please add additional unit tests covering inheritance situations
(single, multiple, and virtual) or explicitly document that
"enclosureOf" is not supported in these cases.
--
https://code.launchpad.net/~johill-lanl/epics-base/epics-base-enclosure-of/+merge/196010
Your team EPICS Core Developers is requested to review the proposed merge of lp:~johill-lanl/epics-base/epics-base-enclosure-of into lp:epics-base.
- References:
- Re: [Merge] lp:~johill-lanl/epics-base/epics-base-enclosure-of into lp:epics-base Jeff Hill
- Navigate by Date:
- Prev:
Re: [Merge] lp:~johill-lanl/epics-base/epics-base-enclosure-of into lp:epics-base Jeff Hill
- Next:
Jenkins build is back to normal : epics-base-3.15 #31 APS Jenkins
- Index:
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
<2013>
2014
2015
2016
2017
2018
2019
2020
2021
2022
2023
2024
- Navigate by Thread:
- Prev:
Re: [Merge] lp:~johill-lanl/epics-base/epics-base-enclosure-of into lp:epics-base Jeff Hill
- Next:
Re: [Merge] lp:~johill-lanl/epics-base/epics-base-enclosure-of into lp:epics-base Jeff Hill
- Index:
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
<2013>
2014
2015
2016
2017
2018
2019
2020
2021
2022
2023
2024
|