Subject: |
Re: [Merge] lp:~johill-lanl/epics-base/epics-base-enclosure-of into lp:epics-base |
From: |
Andrew Johnson <[email protected]> |
To: |
Jeff Hill <[email protected]> |
Date: |
Wed, 20 Nov 2013 21:33:44 -0000 |
This looks very similar to the CONTAINER macro from dbDefs.h, although slightly cleaner to use since the C++ compiler can deduce both types from the pointer-to-member argument. Is this as type-safe as the GNU version of CONTAINER, which checks that the member's data type matches the pointer? I note that CONTAINER works for C code, whereas this is pure C++.
My main concern is getting the name right; since we're already using the word Container would it make sense to use that instead of Enclosure?
Also, should we move the CONTAINER macro into this header (with guards to allow it to be included from C code)?
--
https://code.launchpad.net/~johill-lanl/epics-base/epics-base-enclosure-of/+merge/196010
Your team EPICS Core Developers is requested to review the proposed merge of lp:~johill-lanl/epics-base/epics-base-enclosure-of into lp:epics-base.
- References:
- [Merge] lp:~johill-lanl/epics-base/epics-base-enclosure-of into lp:epics-base Jeff Hill
- Navigate by Date:
- Prev:
[Merge] lp:~johill-lanl/epics-base/epics-base-enclosure-of into lp:epics-base Jeff Hill
- Next:
Re: [Merge] lp:~johill-lanl/epics-base/epics-base-enclosure-of into lp:epics-base Jeff Hill
- Index:
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
<2013>
2014
2015
2016
2017
2018
2019
2020
2021
2022
2023
2024
- Navigate by Thread:
- Prev:
[Merge] lp:~johill-lanl/epics-base/epics-base-enclosure-of into lp:epics-base Jeff Hill
- Next:
Re: [Merge] lp:~johill-lanl/epics-base/epics-base-enclosure-of into lp:epics-base Jeff Hill
- Index:
2002
2003
2004
2005
2006
2007
2008
2009
2010
2011
2012
<2013>
2014
2015
2016
2017
2018
2019
2020
2021
2022
2023
2024
|